From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove all "INTERFACE ROUTINES" style comments |
Date: | 2019-01-11 03:42:36 |
Message-ID: | 7200.1547178156@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Fri, Jan 11, 2019 at 12:58 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> A number of postgres files have sections like heapam's
>> * INTERFACE ROUTINES
>>
>> They're often out-of-date, and I personally never found them to be
>> useful. A few people, including yours truly, have been removing a few
>> here and there when overhauling a subsystem to avoid having to update
>> and then adjust them.
>> I think it might be a good idea to just do that for all at once.
> +1
I agree we don't maintain them well, so it'd be better to remove them,
as long as we make sure any useful info gets transferred someplace else
(like per-function header comments).
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2019-01-11 03:48:32 | Re: How does the planner determine plan_rows ? |
Previous Message | Amit Kapila | 2019-01-11 03:35:53 | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |