Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Quan Zongliang <quanzongliang(at)yeah(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date: 2021-07-08 06:23:58
Message-ID: 71FCA2F8-FFD2-43FA-9B99-AFF3F01508D6@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Jul 2021, at 07:01, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Jul 08, 2021 at 12:49:25AM -0400, Tom Lane wrote:
>> Since we're already past beta2, I'm not sure that's a good idea. We
>> can't really treat pageinspect 1.9 as something that the world has
>> never seen.
>
> Yeah, that's why I would object to new changes in 1.9 and
> REL_14_STABLE. So my take would be to just have 1.10, and do those
> changes on HEAD.

+1, this should go into a 1.10 version.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message osumi.takamichi@fujitsu.com 2021-07-08 06:54:45 Failed transaction statistics to measure the logical replication progress
Previous Message Boris Kolpackov 2021-07-08 06:12:25 Re: Pipeline mode and PQpipelineSync()