| From: | Arthur Zakirov <zaartur(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Atsushi Torikoshi <atorik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add pg_file_sync() to adminpack |
| Date: | 2020-01-24 04:28:29 |
| Message-ID: | 7187240f-b66f-34bb-233f-7130f0d1223b@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/01/17 16:05, Fujii Masao wrote:
> On 2020/01/17 13:36, Michael Paquier wrote:
>> Yeah, that should be either ERROR and return a void result, or issue a
>> WARNING/ERROR (depending on the code path, maybe PANIC?) with a
>> boolean status returned if there is a WARNING. Mixing both concepts
>> with an ERROR all the time and always a true status is just weird,
>> because you know that if no errors are raised then the status will be
>> always true. So there is no point to have a boolean status to begin
>> with.
>
> OK, so our consensus is to return void on success and throw an error
> otherwise. Attached is the updated version of the patch.
Thank you for the new version!
It is compiled and passes the tests. There is the documentation and it
is built too without an error.
It seems that consensus about the returned type was reached and I marked
the patch as "Ready for Commiter".
--
Arthur
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-01-24 05:08:45 | Re: proposal: schema variables |
| Previous Message | Peter Geoghegan | 2020-01-24 02:27:49 | Re: Improve search for missing parent downlinks in amcheck |