| From: | Yushi Ogiwara <btogiwarayuushi(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for consume_xids advancing XIDs incorrectly |
| Date: | 2024-10-29 09:00:24 |
| Message-ID: | 710b46d68d053eac91c9c8ec9feea09d@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>
>>
>> consumed = XidSkip(nextXid);
>> if (consumed > 0)
>> TransamVariables->nextXid.value += (uint64) consumed;
>>
>> BTW, the code snippet above in consume_xids_shortcut() could
>> potentially set
>> the next XID to a value below FirstNormalTransactionId? If yes, we
>> should account for
>> FirstNormalFullTransactionId when increasing the next XID, similar to
>> how FullTransactionIdAdvance() handles it.
>
> Good catch. I agree with you. We need to do something similar to what
> FullTransactionIdAdvance() does so that it does not appear as a
> special 32-bit XID.
>
> Regards,
I think this is not the case since XidSkip returns min(UINT32_MAX - 5 -
low, *), which prevents the wrap-around of nextXid.
Regards,
Yushi Ogiwara
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-10-29 09:23:37 | Re: define pg_structiszero(addr, s, r) |
| Previous Message | Peter Eisentraut | 2024-10-29 08:47:30 | Re: Support regular expressions with nondeterministic collations |