Re: Case Conversion Fix for MB Chars

From: Volkan YAZICI <volkan(dot)yazici(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-tr-genel(at)postgresql(dot)org
Subject: Re: Case Conversion Fix for MB Chars
Date: 2005-11-27 10:14:37
Message-ID: 7104a7370511270214sab32cbdw454fc41056640871@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-tr-genel

On 11/27/05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Doesn't this just move the failure cases around?

I don't think so. I've tried to fix every tolower/toupper related
problem (depending on the MB characters) I found in the code. If
there's still a problem with them, it should be related with the
pg_wchar_tb concept in utils/mb/wchar.c (AFAIC, the last remaning part
about this case conversion mess is the one related with PQfnumber -
which needs a very different approach.)

> The really fundamental problem is that tolower/toupper don't work
> on wchar_t.

Yes, indeed. I agree with you to find a proper solution for character
set handling. But, IMHO, it's better to have a-patchy working system
instead of a not working one. Put yourself in our position, we're
trying to give enterprise solutions to our customers and ILIKE,
lower/upper doesn't work in the product that we support. We can work
with a small patch instead of waiting next releases for an exact
solution to the problem.

Regards.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Volkan YAZICI 2005-11-27 10:58:47 Re: [PATCHES] Case Conversion Fix for MB Chars
Previous Message Bruce Momjian 2005-11-27 03:14:50 Re: Patch to allow contrib/pgbench files to have blank lines

Browse pgsql-tr-genel by date

  From Date Subject
Next Message Volkan YAZICI 2005-11-27 10:58:47 Re: [PATCHES] Case Conversion Fix for MB Chars
Previous Message Tom Lane 2005-11-27 00:55:11 Re: Case Conversion Fix for MB Chars