Re: PGXS: REGRESS_OPTS=--load-language=plpgsql

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Feb 18, 2010 at 11:38 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> ... Let me point out that
>> choosing to install plpgsql by default has already broken "--single"
>> restore of practically every pg_dump out there. Nobody batted an eye
>> about that. Why are we suddenly so concerned about its effects on
>> unnamed test suites?

> I am still of the opinion that changing this was a bad idea for
> exactly this reason. We could perhaps ameliorate this problem by
> implementing CREATE OR REPLACE for languages and emitting that
> instead; then the command in the dump would be a noop.

Not really going to help for existing dumps (nor future dumps made
with pre-9.0 pg_dump versions).

However, the case that is probably going to be the most pressing is
pg_upgrade, which last I heard insists on no errors during the restore
(and I think that's a good thing). That uses the new version's pg_dump
so a fix involving new syntax would cover it.

Did we have consensus on exactly what CREATE OR REPLACE LANGUAGE would
do? Particularly in cases where the existing definition doesn't match
pg_pltemplate?

regards, tom lane