Re: PATCH: two slab-like memory allocators

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, John Gorman <johngorman2(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: two slab-like memory allocators
Date: 2017-03-04 04:02:29
Message-ID: 70336470-6428-cfc1-eb15-d94e74d321c9@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/04/2017 02:58 AM, Andres Freund wrote:
> On 2017-03-01 22:19:30 -0800, Andres Freund wrote:
>> On 2017-03-02 04:36:23 +0100, Tomas Vondra wrote:
>>> I've noticed two minor typos:
>>>
>>> 1) That is solved this by creating ...
>>> - extra "this"
>>>
>>> 2) Given this, routines like pfree their corresponding context ...
>>> - missing "find" or "determine"
>>
>> Will fix.
>
> And done.
>
>>> I also see you've explicitly mentioned the callbacks were added
>>> in 9.5. Doesn't that somewhat reintroduce the historical
>>> account?
>>
>> That section I just moved up, the version reference was there
>> before. I left it in, because it seemed new enough to still be
>> somewhat relevant; removed and added it, not sure what's better.
>
> Left that in place for now.
>

Yeah. I haven't realized it was just moved a bit, and moreover it
probably makes sense to have some comments regarding differences between
current versions. So +1 to that.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-03-04 04:09:05 Re: Automatic cleanup of oldest WAL segments with pg_receivexlog
Previous Message Peter Geoghegan 2017-03-04 03:25:04 Re: GUC for cleanup indexes threshold.