"duplicated" wait events

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: "duplicated" wait events
Date: 2023-08-04 15:07:51
Message-ID: 701f45b5-13a3-6d75-cd24-835cc0716ecb@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

while working on the new system catalog pg_wait_event (see [1]) I noticed that some wait
events are currently "duplicated":

postgres=# select wait_event_name,count(*) from pg_wait_event group by wait_event_name having count(*) > 1;
wait_event_name | count
-----------------+-------
SyncRep | 2
WALWrite | 2
(2 rows)

Indeed:

SynRep currently appears in "IPC" and "LWLock" (see [2])
WALWrite currently appears in "IO" and "LWLock" (see [2])

I think that can lead to confusion and it would be better to avoid duplicate wait event
name across Wait Class (and so fix those 2 ones above), what do you think?

[1]: https://www.postgresql.org/message-id/0e2ae164-dc89-03c3-cf7f-de86378053ac%40gmail.com
[2]: https://www.postgresql.org/docs/current/monitoring-stats.html

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-08-04 15:08:21 Re: WIP: new system catalog pg_wait_event
Previous Message Drouvot, Bertrand 2023-08-04 14:22:54 WIP: new system catalog pg_wait_event