Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: fabriziomello(at)gmail(dot)com
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.
Date: 2019-05-22 18:01:38
Message-ID: 7015.1558548098@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello(at)gmail(dot)com> writes:
> Just one doubt, why use LATERAL with pg_get_publication_tables SRF instead
> of JOIN direct to pg_publication_rel?

Yes, LATERAL is just a noise word in this context, but I think
it's good for documentation purposes.

If you're asking why I used a comma instead of JOIN ... ON TRUE,
it's because I don't find the latter to be particularly readable
or good style. YMMV.

(I agree it's a little weird that the original coding had a mix
of comma and JOIN syntax, but I did not feel a need to revisit
that.)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2019-05-22 19:54:54 Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.
Previous Message Fabrízio de Royes Mello 2019-05-22 17:47:41 Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.