Re: Missing comma?

Thanks!

P.S. Looking at the final sentence:

"Columns used to form “replica identity” for rows: d = default (primary
key, if any), n = nothing, f = all columns, i = index with
indisreplident set, or default"

in my opinion it's a little unclear what "or default" means at the end,
because the comma is used to separate enumeration elements ("d = default
<...>, n = nothing, f = all columns, i = index <...>") and inside the
element description ("i = index with indisreplident set, or default").
Therefore here is an additional patch from me to clarify this place,
thanks to Alexander Lakhin for help.

On 2020-05-13 16:23, Daniel Gustafsson wrote:
>> On 13 May 2020, at 12:20, Marina Polyakova
>> <m(dot)polyakova(at)postgrespro(dot)ru> wrote:
>
>> https://www.postgresql.org/docs/current/catalog-pg-class.html says
>> "Columns used to form “replica identity” for rows: d = default
>> (primary key, if any), n = nothing, f = all columns i = index with
>> indisreplident set, or default". Am I wrong, or is there a missing
>> comma (or other punctuation mark) before "i = index"?..
>
> I agree with this, there should be a comma between "f = all columns"
> and "i =
> index with.." per the below:
>
> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index ce33df9e58..cbd76e1bf5 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -1935,7 +1935,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration
> count&gt;</replaceable>:<replaceable>&l
> Columns used to form <quote>replica identity</quote> for rows:
> <literal>d</literal> = default (primary key, if any),
> <literal>n</literal> = nothing,
> - <literal>f</literal> = all columns
> + <literal>f</literal> = all columns,
> <literal>i</literal> = index with
> <structfield>indisreplident</structfield> set, or default
> </entry>
> </row>
>
> cheers ./daniel

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company