| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Design of pg_stat_subscription_workers vs pgstats |
| Date: | 2022-02-24 09:53:02 |
| Message-ID: | 6f7701b0-ce5c-d01c-18f2-5de3a02ff6b6@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.02.22 02:32, Masahiko Sawada wrote:
> On Wed, Feb 23, 2022 at 12:08 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>>
>> Hi. Below are my review comments for the v1 patch.
>
> Thank you for the comments! I've attached the latest version patch
> that incorporated all comments I got so far. The primary change from
> the previous version is that the subscription statistics live globally
> rather than per-database.
I don't think the name pg_stat_subscription_activity is a good choice.
We have a view called pg_stat_activity, which is very well known. From
that perspective, "activity" means what is happening right now or what
has happened most recently. The reworked view in this patch does not
contain that (we already have pg_stat_subscription for that), but it
contains accumulated counters.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2022-02-24 09:58:33 | Re: PATCH: add "--config-file=" option to pg_rewind |
| Previous Message | Peter Eisentraut | 2022-02-24 09:48:41 | Re: Design of pg_stat_subscription_workers vs pgstats |