From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Cleanup - Removal of unused function parameter from CopyReadBinaryAttribute |
Date: | 2020-06-18 16:35:06 |
Message-ID: | 6e993f1e-e895-c8af-2002-a3412c146319@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/06/18 23:09, Bharath Rupireddy wrote:
> On Thu, Jun 18, 2020 at 7:01 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>>
>> Hi,
>>
>> While checking copy from code I found that the function parameter
>> column_no is not used in CopyReadBinaryAttribute. I felt this could be
>> removed.
>> Attached patch contains the changes for the same.
>> Thoughts?
>>
>
> I don't see any problem in removing this extra parameter.
>
> However another thought, can it be used to report a bit meaningful
> error for field size < 0 check?
column_no was used for that purpose in the past, but commit 0e319c7ad7
changed that. If we want to use column_no in the log message again,
it's better to check why commit 0e319c7ad7 got rid of column_no from
the message.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-06-18 16:35:54 | Re: jsonpath versus NaN |
Previous Message | Alexander Korotkov | 2020-06-18 16:34:32 | Re: jsonpath versus NaN |