Re: Minimal logical decoding on standbys

Hi,

On 2/4/21 6:33 PM, Fabrízio de Royes Mello wrote:
>
> On Thu, Feb 4, 2021 at 1:49 PM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com
> <mailto:bdrouvot(at)amazon(dot)com>> wrote:
> >
> > Had to do a little change to make it compiling again (re-add the
> heapRel argument in _bt_delitems_delete() that was removed by commit
> dc43492e46c7145a476cb8ca6200fc8eefe673ef).
> >
> > Given that this attached v9 version:
> >
> > compiles successfully on current master
> > passes "make check"
> > passes the 2 associated tap tests "make -C src/test/recovery check
> PROVE_TESTS=t/022_standby_logical_decoding_xmins.pl
> <http://022_standby_logical_decoding_xmins.pl> PROVE_FLAGS=-v"  and
> "make -C src/test/recovery check
> PROVE_TESTS=t/023_standby_logical_decoding_conflicts.pl
> <http://023_standby_logical_decoding_conflicts.pl> PROVE_FLAGS=-v"
> >
>
> Perfect thanks... will review ASAP!

Thanks!

Just made minor changes to make it compiling again on current master
(mainly had to take care of ResolveRecoveryConflictWithSnapshotFullXid()
that has been introduced in e5d8a99903).

Please find enclosed the new patch version that currently passes "make
check" and the 2 associated TAP tests.

I'll have a look to the whole thread to check if there is anything else
waiting in the pipe regarding this feature, unless some of you know off
the top of their head?

Bertrand