Re: pg_partition_tree crashes for a non-defined relation

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Date: 2018-12-13 06:34:56
Message-ID: 6dc3e986-597c-6e83-4d55-5f00313a68b2@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018/12/12 9:52, Michael Paquier wrote:
> On Mon, Dec 10, 2018 at 10:52:37PM +0900, Michael Paquier wrote:
>> OK. Sure, let's do as you suggest then. I'll wait a couple of days
>> before committing the patch so as if someone has extra comments they
>> have the time to post. So please feel free to comment!
>
> And done this way. Thanks for the input, Stephen and others!

Thank you Michael for taking care of this. I agree with the consensus
that instead of throwing an error for unsupported relkinds,
pg_partition_tree should rather return single row containing NULL for all
columns.

Regards,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pablo Iranzo Gómez 2018-12-13 06:43:21 Re: Introducing SNI in TLS handshake for SSL connections
Previous Message Kyotaro HORIGUCHI 2018-12-13 05:59:20 Re: Pluggable Storage - Andres's take