Re: postgres_fdw batching vs. (re)creating the tuple slots

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw batching vs. (re)creating the tuple slots
Date: 2021-06-09 10:30:17
Message-ID: 6dc1c07b-87e6-63e6-10b3-cca4698361fb@enterprisedb.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Here's a v2 fixing a silly bug with reusing the same variable in two
nested loops (worked for simple postgres_fdw cases, but "make check"
failed).

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-create-copy-of-a-descriptor-for-batching-v2.patch text/x-patch 1.5 KB
0002-initialize-slots-only-once-for-batching-v2.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-06-09 10:42:34 Re: Decoding speculative insert with toast leaks memory
Previous Message Hassan Camacho Cadre 2021-06-09 10:30:15 How to pass a parameter in a query to postgreSQL 11