Re: Duplicate assignment in Unicode/convutils.pm

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Duplicate assignment in Unicode/convutils.pm
Date: 2017-04-07 16:20:55
Message-ID: 6db00b42-3c86-6352-212d-470d233889cf@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/07/2017 09:32 AM, Kyotaro HORIGUCHI wrote:
> Hi, I found that convutils.pl contains a harmless duplicate
> assignemnt.
>
>> my $out = {f => $fname, l => $.,
>> code => hex($1),
>> ucs => hex($2),
>> comment => $4,
>> direction => BOTH,
>> f => $fname,
>> l => $.
>> };
>
> Of course this is utterly harmless but wrong.
>
> The attached patch fixes this following other perl files around.
> No similar mistake is not found there.

Committed, thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-04-07 16:28:30 Re: Undefined psql variables
Previous Message Jeff Janes 2017-04-07 16:12:29 Re: pg_basebackup: Allow use of arbitrary compression program