Re: Proposal for Updating CRC32C with AVX-512 Algorithm.

From: "Sterrett, Matthew" <matthewsterrett2(at)gmail(dot)com>
To: "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>
Subject: Re: Proposal for Updating CRC32C with AVX-512 Algorithm.
Date: 2024-12-19 00:00:37
Message-ID: 6cd9e6eb-e54e-4465-892f-fa1ef097cc42@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/7/2024 12:42 AM, Devulapalli, Raghuveer wrote:
>> [0] https://cirrus-ci.com/task/6023394207989760
>> [1] https://cirrus-ci.com/task/5460444254568448
>> [2] https://cirrus-ci.com/task/6586344161411072
>
> I was able to fix [0] and [1], but I can't think of why [2] fails. When I tried to reproduce this locally, I get a different unrelated error. Any idea why I am seeing this?
>
> LINK : fatal error LNK1181: cannot open input file 'C:\Program Files\Git\nologo'
>
> Commands: meson setup build && cd build && meson compile

Hello! I'm Matthew Sterrett and I'm a coworker of Raghuveer; he asked me
to look into the Windows build failures related to pg_comp_crc32c.

It seems that the only thing that was required to fix that is to mark
pg_comp_crc32c as PGDLLIMPORT, so I added a patch that does just that.
I'm new to working with mailing lists, so please tell me if I messed
anything up!

Matthew Sterrett

Attachment Content-Type Size
v10-0001-Add-a-Postgres-SQL-function-for-crc32c-benchmark.patch text/plain 4.9 KB
v10-0002-Refactor-consolidate-x86-ISA-and-OS-runtime-chec.patch text/plain 11.7 KB
v10-0003-Add-AVX-512-CRC32C-algorithm-with-a-runtime-chec.patch text/plain 41.9 KB
v10-0004-Mark-pg_comp_crc32c-as-PGDLLIMPORT-for-Windows-b.patch text/plain 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anton A. Melnikov 2024-12-19 00:10:30 Re: Change GUC hashtable to use simplehash?
Previous Message Peter Smith 2024-12-18 23:28:25 Re: Logical Replication of sequences