| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, craig(at)2ndquadrant(dot)com |
| Subject: | Re: REPLICA IDENTITY FULL |
| Date: | 2017-06-23 19:45:48 |
| Message-ID: | 6c7dfbb8-506a-e8f2-196e-3912db2a6307@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/23/17 13:14, Alvaro Herrera wrote:
> Andres Freund wrote:
>> On 2017-06-23 13:05:21 -0400, Alvaro Herrera wrote:
>>> Tom Lane wrote:
>>>> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>>>> Any thoughts about keeping datumAsEqual() as a first check? I did some
>>>>> light performance tests, but it was inconclusive.
>>>>
>>>> Seems like it would tend to be a win if, in fact, the values are
>>>> usually equal. If they're usually not, then it's a loser. Do
>>>> we have any feeling for which case is more common?
>>
>> Seems like a premature optimization to me - if you care about
>> performance and do this frequently, you're not going to end up using
>> FULL. If we want to performance optimize, it'd probably better to
>> lookup candidate keys and use those if available.
>
> I can get behind that argument.
Thanks for the feedback. I have committed it after removing the
datumIsEqual() call.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-23 20:04:48 | Re: Same expression more than once in partition key |
| Previous Message | Peter Eisentraut | 2017-06-23 18:52:50 | Re: shift_sjis_2004 related autority files are remaining |