| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Bizarre coding in recovery target GUC management |
| Date: | 2020-10-23 08:07:21 |
| Message-ID: | 6c30a0e9-eecb-7b5a-9e3f-63108fa067f7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-10-12 18:00, Tom Lane wrote:
> Would someone explain to me why assign_recovery_target_lsn and related GUC
> assign hooks throw errors, rather than doing so in the associated check
> hooks? An assign hook is not supposed to throw an error. Full stop, no
> exceptions. We wouldn't bother to separate those hooks otherwise.
That code is checking whether more than one recovery target GUC has been
set. I don't think the check hook sees the right state to be able to
check that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-10-23 08:14:12 | Re: warn_unused_results |
| Previous Message | Michael Paquier | 2020-10-23 08:02:11 | Re: "unix_socket_directories" should be GUC_LIST_INPUT? |