Re: [PATCH] Add sortsupport for range types and btree_gist

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add sortsupport for range types and btree_gist
Date: 2024-12-09 17:10:53
Message-ID: 6bd891c9e3aa12baea5c938267bdb5a1e50a299e.camel@oopsware.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am Samstag, dem 30.11.2024 um 22:18 +0500 schrieb Andrey Borodin:
> We tried to go that route, random DEBUG1 lines were breaking tests
> (autovacuum or something like that, there was something non-
> deterministic). I think we can dig exact reason from 2021 thread why
> we abandoned that idea...
>
> I think we have two options:
> 1. Just do not commit tests. We ran it manually, saw that paths are
> taken, we are happy.

So here's a version with the original, unchanged regression tests and
injection point removed (i hope i forgot nothing to revert).

This version also fixes cidr sortsupport (thanks again Andrey for
spotting this), where i accidently used inet instead of the correct
cidr datatype to pass down to the sortsupport function.

Thanks,
Bernd

Attachment Content-Type Size
0001-Add-support-for-sorted-gist-index-builds-to-btree_gi.patch text/x-patch 44.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-12-09 17:20:49 Re: remove pgrminclude?
Previous Message Pavel Stehule 2024-12-09 16:54:26 Re: proposal: schema variables