Re: Make finding openssl program a configure or meson option

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Make finding openssl program a configure or meson option
Date: 2022-10-18 16:46:53
Message-ID: 6b6df244-584b-1a48-484a-1f95a1ded097@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12.10.22 03:08, Michael Paquier wrote:
> On Tue, Oct 11, 2022 at 05:06:22PM +0200, Peter Eisentraut wrote:
>> Various test suites use the "openssl" program as part of their setup. There
>> isn't a way to override which openssl program is to be used, other than by
>> fiddling with the path, perhaps. This has gotten increasingly problematic
>> with some of the work I have been doing, because different versions of
>> openssl have different capabilities and do different things by default.
>> This patch checks for an openssl binary in configure and meson setup, with
>> appropriate ways to override it. This is similar to how "lz4" and "zstd"
>> are handled, for example. The meson build system actually already did this,
>> but the result was only used in some places. This is now applied more
>> uniformly.
>
> openssl-env allows the use of the environment variable of the same
> name. This reminds me a bit of the recent interferences with GZIP,
> for example.

Okay, I see what you meant here now. openssl-env is the man page
describing environment variables used by OpenSSL. I don't see any
conflicts with what is being proposed here.

> This patch is missing one addition of set_single_env() in
> vcregress.pl, and one update of install-windows.sgml where all the
> supported environment variables for commands are listed.

Added. New patch attached.

Attachment Content-Type Size
v2-0001-Make-finding-openssl-program-a-configure-or-meson.patch text/plain 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-10-18 16:59:09 Re: Checking for missing heap/index files
Previous Message Robert Haas 2022-10-18 16:44:38 Re: Checking for missing heap/index files