Re: Crash when partition column specified twice

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Crash when partition column specified twice
Date: 2017-05-01 00:13:36
Message-ID: 6a6eeb46-e5ac-7a1d-ff3d-8090a8c32ed5@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/04/29 2:53, Robert Haas wrote:
> On Fri, Apr 28, 2017 at 7:23 AM, Beena Emerson <memissemerson(at)gmail(dot)com> wrote:
>> Hello Amit,
>>
>> The extra n->is_from_type = false; seems to be added by mistake?
>>
>> @@ -11888,6 +11891,8 @@ TableFuncElement: ColId Typename
>> opt_collate_clause
>> n->is_local = true;
>> n->is_not_null = false;
>> n->is_from_type = false;
>> + n->is_from_type = false;
>> + n->is_from_parent = false;
>> n->storage = 0;
>> n->raw_default = NULL;
>> n->cooked_default = NULL;
>
> Good catch. Committed after fixing that issue.

Thanks both.

Regards,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-05-01 00:31:03 Re: Logical replication in the same cluster
Previous Message Andres Freund 2017-04-30 23:21:33 Re: CTE inlining