| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add pow(), aka power(), function to pgbench. |
| Date: | 2017-12-29 13:51:10 |
| Message-ID: | 6a65f141-d1e2-d30b-397a-57fffedd2965@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 12/29/2017 08:04 AM, Raúl Marín Rodríguez wrote:
>
> Probably "0?". Although an int with leading zeros is usually an
> octal number, so window's rational fails me.
>
>
> You are right. From the C99 standard:
>
> The exponent always contains at least two digits, and only as many
> more digits as necessary to represent the exponent. If the value
> is zero, the exponent is zero.
>
>
> Both solutions seem fine to me. Also, as these couple of tests were
> added to check for int overflow and we no longer do any int
> operations, removing them wouldn't be a big loss.
> --
> *Raúl Marín Rodríguez
> *carto.com <http://carto.com/>
>
0? seems right. I have committed that.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-12-29 14:07:06 | pgsql: Extend near-wraparound hints to include replication slots |
| Previous Message | Andrew Dunstan | 2017-12-29 13:43:48 | pgsql: Allow leading zero on exponents in pgbench test results |