| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ICU locale validation / canonicalization |
| Date: | 2023-03-31 10:11:56 |
| Message-ID: | 6a36e663b17be3e52a473635d691c76b59263c67.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2023-03-30 at 08:59 +0200, Peter Eisentraut wrote:
> I don't think we should show the notice when the canonicalization
> doesn't change anything. This is not useful:
>
> +NOTICE: using language tag "und-u-kf-upper" for locale "und-u-kf-
> upper"
Done.
> Also, the message should be phrased more from the perspective of the
> user instead of using ICU jargon, like
>
> NOTICE: using canonicalized form "%s" for locale specification "%s"
>
> (Still too many big words?)
Changed to:
NOTICE: using standard form "%s" for locale "%s"
> Needs documentation updates in doc/src/sgml/charset.sgml.
I made a very minor update. Do you have something more specific in
mind?
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Canonicalize-ICU-locale-names-to-language-tags.patch | text/x-patch | 22.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-03-31 10:16:36 | Re: Infinite Interval |
| Previous Message | shiy.fnst@fujitsu.com | 2023-03-31 10:04:10 | RE: Data is copied twice when specifying both child and parent table in publication |