Re: pgsql: Fix (hopefully for the last time) problems with datetime values

From: Larry Rosenman <ler(at)lerctr(dot)org>
To: Michael Fuhr <mike(at)fuhr(dot)org>
Cc: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix (hopefully for the last time) problems with datetime values
Date: 2005-10-09 20:43:20
Message-ID: 6FDBEE93-8D96-4D70-9E41-4FB625CF726C@lerctr.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On Oct 9, 2005, at 1:56 PM, Michael Fuhr wrote:

> On Sun, Oct 09, 2005 at 02:21:47PM -0300, Tom Lane wrote:
>
>> Fix (hopefully for the last time) problems with datetime values
>> displaying
>> like '23:59:60' because of fractional-second roundoff problems.
>> Trying
>> to control this upstream of the actual display code was hopeless;
>> the right
>> way is to explicitly round fractional seconds in the display code
>> and then
>> refigure the results if the fraction rounds up to 1. Per bug #1927.
>>
>
> This change causes my FreeBSD 4.11-STABLE box and a couple of
> FreeBSD 6
> members of the buildfarm to fail while building ecpg:
>
> timestamp.c: In function `timestamp2tm':
> timestamp.c:195: `INT_MAX' undeclared (first use in this function)
>
> Including <limits.h> in src/interfaces/ecpg/pgtypeslib/timestamp.c
> fixes the problem.

firefly (my UnixWare box as well) dies with this.

LER

>
> --
> Michael Fuhr
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
>

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-351-4152 E-Mail: ler(at)lerctr(dot)org
US Mail: 3535 Gaspar Drive, Dallas, TX 75220-3611

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Fuhr 2005-10-09 23:27:40 Re: pgsql: Fix (hopefully for the last time) problems with datetime values
Previous Message Michael Fuhr 2005-10-09 18:56:42 Re: pgsql: Fix (hopefully for the last time) problems with datetime values