From: | "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Win 32 hackers PGSQL" <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Re: statistics process shutting down |
Date: | 2004-11-30 21:01:48 |
Message-ID: | 6EE64EF3AB31D5448D0007DD34EEB3412A7547@Herge.rcsinc.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 |
> > Maybe Magnus might comment here. This doesn't explain why the read
call
> > is failing but I'm pretty sure the error code is not being properly
> > returned.
>
> I recall a lot of angst about whether the encoding of
WSAGetLastError()
> is compatible with errno values, but I forget what the conclusion was.
> Can we just assign to errno like that, or do we need a mapping
function?
Ah. My bad.
/backend/prot/win32/socket.c
static void
TranslateSocketError(void) etc. This puts the value in errno like it is
suppoed to be. MS recv() does not (I checked) so this is definately a
bug in pipe.c, since it is reasonable for the caller to expect errno to
be set to something.
Also, recv() and read() return completely different error codes :-). So
any caller has to be careful not to make assumptions about errno.
Merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Merlin Moncure | 2004-11-30 21:32:25 | Re: statistics process shutting down |
Previous Message | Tom Lane | 2004-11-30 20:45:04 | Re: statistics process shutting down |