From: | "Rocco Altier" <RoccoA(at)Routescape(dot)com> |
---|---|
To: | "Peter Eisentraut" <peter_e(at)gmx(dot)net> |
Cc: | <pgsql-patches(at)postgresql(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at> |
Subject: | Re: Changes for AIX buildfarm |
Date: | 2005-07-21 17:10:29 |
Message-ID: | 6E0907A94904D94B99D7F387E08C4F5730EBB7@FALCON.INSIGHT |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Attached is a patch for HEAD to implement Peter's suggestion to set the
SHLIB_LINK in the contrib modules that need it.
Also, this changes Makefile.aix to use SHLIB_LINK instead of LIBS so
that the changes to the contrib Makefiles are picked up correctly.
Further this makes it match more closely the link rules from
Makefile.shlib.
-rocco
> -----Original Message-----
> From: Peter Eisentraut [mailto:peter_e(at)gmx(dot)net]
> Sent: Wednesday, July 20, 2005 2:12 PM
> To: Rocco Altier
> Cc: pgsql-patches(at)postgresql(dot)org; Tom Lane; Andrew Dunstan;
> Zeugswetter Andreas DAZ SD
> Subject: Re: [PATCHES] Changes for AIX buildfarm
>
>
> Tom Lane wrote:
> > Fair enough. But I'm concerned about the proposed patch because it
> > seems to revert a deliberate change made some time ago:
> >
> >
> http://developer.postgresql.org/cvsweb.cgi/pgs>
ql/src/Makefile.shlib#r
> >ev1.65
> > http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php
> >
> > so I think we need more eyeballs on the problem before deciding this
> > is a good fix.
>
> A potentially more correct solution would be to set SHLIB_LINK in the
> makefiles of the affected modules only. Certainly we don't want to
> link with all libraries all the time.
>
> --
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
>
Attachment | Content-Type | Size |
---|---|---|
aix.contrib.patch | application/octet-stream | 4.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-07-21 18:03:08 | Re: Roles - SET ROLE Updated |
Previous Message | Bruce Momjian | 2005-07-21 04:57:27 | Re: pgsql: Add 'day' field to INTERVAL so 1 day interval |