From: | "Rocco Altier" <RoccoA(at)Routescape(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
Cc: | "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Changes for AIX buildfarm |
Date: | 2005-07-18 20:12:37 |
Message-ID: | 6E0907A94904D94B99D7F387E08C4F5730E910@FALCON.INSIGHT |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
The problem trying to be fixed there seems to be related to libraries
being linked into the backend vs. frontend.
Since the contrib shared library modules are linked in a similar
environment backend code I decided to use BE_DLLLIBS.
Here is the new patch (which doesn't affect libpq).
-rocco
Index: src/makefiles/Makefile.aix
===================================================================
RCS file: /projects/cvsroot/pgsql/src/makefiles/Makefile.aix,v
retrieving revision 1.21
diff -c -r1.21 Makefile.aix
*** src/makefiles/Makefile.aix 9 Oct 2002 16:21:54 -0000 1.21
--- src/makefiles/Makefile.aix 18 Jul 2005 19:59:59 -0000
***************
*** 15,20 ****
--- 15,21 ----
LDFLAGS_SL = -Wl,-bnoentry -Wl,-H512 -Wl,-bM:SRE
endif
+ BE_DLLLIBS= $(LIBS)
EXPSUFF= .exp
IMPSUFF= .imp
> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: Monday, July 18, 2005 12:47 PM
> To: Andrew Dunstan
> Cc: Rocco Altier; Zeugswetter Andreas DAZ SD;
> pgsql-patches(at)postgresql(dot)org
> Subject: Re: [PATCHES] Changes for AIX buildfarm
>
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Tom Lane wrote:
> >> Er, which buildfarm report is prompting this?
>
> > Rocco is probably doing what I normally ask, which is to get builds
> > working before starting to upload results to the buildfarm
> server (a
> > request which is more honored in the breach than the observance).
>
> Fair enough. But I'm concerned about the proposed patch because it
> seems to revert a deliberate change made some time ago:
>
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib#rev1
.65
http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php
so I think we need more eyeballs on the problem before deciding this is
a good fix.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-07-18 20:57:47 | Re: thousands comma numeric formatting in psql |
Previous Message | Bruce Momjian | 2005-07-18 18:58:44 | Re: thousands comma numeric formatting in psql |