Re: Review: Patch to compute Max LSN of Data Pages

From: Amit kapila <amit(dot)kapila(at)huawei(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Muhammad Usama'" <m(dot)usama(at)gmail(dot)com>
Cc: Muhammad Usama <m(dot)usama(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Patch to compute Max LSN of Data Pages
Date: 2012-12-09 05:30:02
Message-ID: 6C0B27F7206C9E4CA54AE035729E9C383BEA1F91@szxeml509-mbx
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Saturday, December 08, 2012 9:44 AM Tom Lane wrote:
Amit kapila <amit(dot)kapila(at)huawei(dot)com> writes:
> On Friday, December 07, 2012 7:43 PM Muhammad Usama wrote:
>>> Although I am thinking why are you disallowing the absolute path of file. Any particular reason?

>> The reason to disallow absolute path is that, we need to test on multiple platforms and to keep the scope little less.

>This argument seems to me to be completely nuts. What's wrong with an
>absolute path? Wouldn't you have to go out of your way to disallow it?

There's nothing wrong with absolute path. I have updated the patch to work for absolute path as well.
Updated patch attached with this mail.

With Regards,
Amit Kapila.

Attachment Content-Type Size
pg_computemaxlsn_v4.patch application/octet-stream 26.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2012-12-09 06:08:31 Re: Review of Row Level Security
Previous Message Joachim Wieland 2012-12-09 04:16:55 Re: parallel pg_dump