From: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: external_pid_file not removed on postmaster exit |
Date: | 2012-07-29 05:00:20 |
Message-ID: | 6C0B27F7206C9E4CA54AE035729E9C382851FB76@szxeml509-mbs |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> From: Tom Lane [tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: Saturday, July 28, 2012 9:46 PM
Amit kapila <amit(dot)kapila(at)huawei(dot)com> writes:
>>> I think it should be removed with proc_exit hook just like the main
>>> postmaster.pid file.
>> external_pid_file is created first time when it is enabled in postgresql.conf
>> I think it should be removed once the parameter external_pid_file is unset;
> Unset?
By Unset, I mean to say when the configuration parameter 'external_pid_file' is disabled (#external_pid_file).
But if the path/filename is changed to different name across restart of server, it will not be able to delete the previous file.
So it will not workout the way I was trying to think.
However if it is deleted at proc_exit as suggested by Peter, there will be no problem.
The reason why I have thought the file not to get deleted at every proc_exit, is
a. Initially I thought it might be un-necessary to delete and re-create the file at server shutdown and start.
b. I was not sure if this file has usage only till server is running.
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2012-07-29 05:53:52 | access to psql variables from server again |
Previous Message | Tom Lane | 2012-07-29 03:14:47 | Re: Adding probes for smgr |