Re: qsort vs MSVC build

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: qsort vs MSVC build
Date: 2006-10-19 18:04:56
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC95@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> >> Is it worth renaming our qsort to pg_qsort to avoid this?
> >> (I'd be inclined to do that via a macro "#define qsort
> pg_qsort", not
> >> by running around and changing all the code.)
>
> > Yeah, I think it is ;-) Just make sure it happens before we pull in
> > stdlib.h, so we don't rename tha tone as well...
>
> No, we'd want to put the macro after stdlib.h, I should think?
> Specifically in port.h, where we play other similar games.

Uh, that's what I meant, I just wrote it backwards. Sorry.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2006-10-19 18:05:22 Re: qsort vs MSVC build
Previous Message Magnus Hagander 2006-10-19 18:04:33 Re: CVS repository rsync