Re: Adminpack build fix

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Adminpack build fix
Date: 2006-10-19 17:49:41
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FC91@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> >> The reason for redeclaring these in the contrib files is to get
> >> DLLIMPORT onto them...
>
> > Interedting - it builds on MSVC without it :-O
>
> > Anyway. That certainly explains why MSVC is complaining -
> it's getting
> > completely different definitions of these variables from the header
> > and from the actual file.
>
> The same redeclaration technique is being used elsewhere
> (pg_buffercache and pg_freespacemap it looks like). Aren't
> you getting warnings there too?

I am - I just started working on getting those done as well. (they were
also living on my list of fix-later ones for some other reasons - the
other reasons now having been fixed)

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2006-10-19 17:52:06 CVS repository rsync
Previous Message Magnus Hagander 2006-10-19 17:49:00 qsort vs MSVC build

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-10-19 17:57:23 Re: Adminpack build fix
Previous Message Tom Lane 2006-10-19 17:47:21 Re: Adminpack build fix