From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] MSVC build broken (again) |
Date: | 2006-10-04 13:05:58 |
Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FC1E@algol.sollentuna.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> >> Would it be possible to move the whole <crtdefs.h> block
> into win32.h?
>
> > Nope, it needs to go before <stdio.h> and friends, unfortunatly.
>
> OK, patch committed as-is then. The whole thing still looks
> awfully icky though, particularly the way pg_config_os.h is
> included in one place for WIN32 and a different place everywhere else.
>
> Would it make sense to split win32.h into two files, one
> that's included in the normal pg_config_os.h place and one
> included after the system includes?
I've been looking at doing this before, but never got around to it. It's
a bit hairy, so it's definitly not something we want to do during beta,
though. But maybe for 8.3.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Zeugswetter Andreas DCP SD | 2006-10-04 13:27:57 | Re: [PATCHES] vcbuild bison check |
Previous Message | Magnus Hagander | 2006-10-04 13:05:57 | qsort_arg needed for msvc build |
From | Date | Subject | |
---|---|---|---|
Next Message | Zeugswetter Andreas DCP SD | 2006-10-04 13:27:57 | Re: [PATCHES] vcbuild bison check |
Previous Message | Magnus Hagander | 2006-10-04 13:05:57 | qsort_arg needed for msvc build |