Re: pgstat: remove delayed destroy / pipe: socket error fix

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Peter Brant" <Peter(dot)Brant(at)wicourts(dot)gov>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pgstat: remove delayed destroy / pipe: socket error fix
Date: 2006-04-06 19:58:42
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0F8E3@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> > Attached are two patches which in combination make pg_stat_activity
> > work reliably for us on Windows.
> > ...
> > pgstat.patch removes the delayed destroy code for backends,
> databases,
> > and tables. Database and table entries are cleaned up immediately
> > upon receipt of the appropriate message.
>
> I'll go ahead and apply the delayed-destroy-removal part
> (just to HEAD for the time being --- seems a bit risky to
> apply it to the stable branches). The Windows-specific
> change sounds like it may need more review.

Actually, I think that's mostly me being confused and taking others with
me ;-)

It's definitly a problem, and we have a solution there. The one thing
I'm still a bit concerned about is: Do we need a CHECK_FOR_INTERRUPTS,
and do we need an upper limit on the spinning. In theory we can spin
with 100% CPU usage, which is not good. So we should either spin a
limited amount of times, or we should perhaps introduce a tiny delay?

//Magnus

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Chris Browne 2006-04-06 20:11:30 AIX FAQ
Previous Message Tom Lane 2006-04-06 19:44:26 Re: pgstat: remove delayed destroy / pipe: socket error fix