From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
---|---|
To: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Copy quoting |
Date: | 2006-01-10 19:51:42 |
Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE92E9A8@algol.sollentuna.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
> > Therefore, included is also a second patch which creates new config
> > options for quoting/separating when doing copy, accessed
> from the main
> > options screen.
>
> I haven't applied this one for the following reasons:
>
> - It is missing a doc update (don't worry about the screen
> shot, just the text).
Right. Coming up here. Can't generate the right screenshots, wrong
platform ;-)
Indent characters also was not documented. Not really sure what it sets?
(well it sets indenting, but of what?)
> - The combo box is not wide enough to display 'Strings' in
> English, which means it almost certainly will be too small in
> some other languages. As a rule of thumb, try to allow 30-50%
> extra space.
Oh. It does show it fine in the list, but not when selected. Bummer.
Fixed, also enlarged the other fields, so they are all the same width.
> - The 'copy sql from...' option on the options tab now seems
> too close to the bottom of the tab. Perhaps the dialogue
> should be enlarged slightly?
Hmm. It looked reasonable on mine, but yeah, a bit on the close edge.
Enlarged another 15 units.
Well, here's the patch. Also properly anchored this time :-)
//Magnus
Attachment | Content-Type | Size |
---|---|---|
pgadmin_copy_quoting3.patch | application/octet-stream | 11.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Faheem Mitha | 2006-01-10 21:28:22 | empty Release.gpg on ftp3.us.postgresql.org |
Previous Message | Magnus Hagander | 2006-01-10 19:32:55 | Commandline patch oops |