Re: patch for win32 dynloader

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers-win32(at)postgresql(dot)org>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: patch for win32 dynloader
Date: 2005-07-28 20:10:42
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE09462C@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

> >> 3) I restarted the postmaster both times. I got this error
> both times.
> >> :25: ERROR: could not load library "C:/Program
> >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error
>
> > Yes. We really need to look at fixing that error message. I had
> > forgotten it completely :-(
>
> > Bruce, you think we can sneak that in after feature freeze? I would
> > call it a bugfix :-)
>
> Me too. That's been on the radar for awhile --- please do
> send in a patch.

Here we go, that wasn't too hard :-)

Apart from adding the error handling, it does one more thing: it changes
the errormode when loading the DLLs. Previously if a DLL was broken, or
referenced other DLLs that couldn't be found, a popup dialog box would
appear on the screen. Which had to be clicked before the backend could
continue. This patch also disables the popup error message for DLL
loads.

I think this is something we should consider doing for the entire
backend - disable those popups, and say we deal with it ourselves. What
do you other win32 hackers thinnk about this?

In the meantime, this patch fixes the error msgs. Please apply for 8.1
and please consider a backpatch to 8.0.

//Magnus

Attachment Content-Type Size
win32_dynloader_err.patch application/octet-stream 2.7 KB

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Audrey Bergeron-Morin 2005-07-28 20:25:32 Re: Can't connect after restart
Previous Message Magnus Hagander 2005-07-28 19:56:27 Re: Can't connect after restart

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2005-07-28 20:26:31 Win32 eventlog level fix
Previous Message Rocco Altier 2005-07-28 18:01:12 Re: AIX - pgport/contrib resolution