Re: Bug in reindexdb's error reporting

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bug in reindexdb's error reporting
Date: 2019-05-10 10:38:06
Message-ID: 6AA7D925-432D-44AB-88C6-4079FDC7D824@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 May 2019, at 12:24, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, May 10, 2019 at 11:02:52AM +0200, Julien Rouhaud wrote:
>> I just noticed that reindexdb could report an extraneous message
>> saying an error happened while reindexing a database if it failed
>> reindexing a table or an index.
>>
>> Trivial fix attached.
>
> Oops. That's true, nice catch. This is older than 9.4, so it needs
> to go all the way down. Let's fix this. Do others have any comments?

Nice catch indeed, LGTM.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kuntal Ghosh 2019-05-10 10:46:09 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Michael Paquier 2019-05-10 10:24:47 Re: Bug in reindexdb's error reporting