Re: Should we remove -Wdeclaration-after-statement?

> On Jan 29, 2024, at 7:35 AM, Isaac Morland <isaac(dot)morland(at)gmail(dot)com> wrote:
>
> On Mon, 29 Jan 2024 at 10:31, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
> -Infinity for refactoring the entire codebase and backpatching.
>
> I don't think anybody is proposing re-working the existing codebase. I understand this to be only about allowing new code to use the newer style. Personally, I like, as much as possible, to use initializations to const variables and avoid assignment operators, so I much prefer to declare at first (and usually only) assignment.

I was responding to Jelte's paragraph upthread:

> On Dec 27, 2023, at 9:59 AM, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
>
> But if the only reason not to remove the
> warning is that then there would be two styles of declaration in the
> codebase, then I'm happy to create another refactoring script that
> moves declarations down to their first usage. (Which could then be run
> on all backbranches to make sure there is no backpatching pain)

I find that kind of gratuitous code churn highly unpleasant.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company