| From: | David Christensen <david(at)endpoint(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Florian Weimer <fweimer(at)bfk(dot)de>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: MySQL-ism help patch for psql |
| Date: | 2010-01-21 18:06:18 |
| Message-ID: | 6A407045-6E82-4B9D-BF96-A5C734F2C2CD@endpoint.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Jan 21, 2010, at 12:02 PM, Tom Lane wrote:
> David Christensen <david(at)endpoint(dot)com> writes:
>> Should the error messages between the SHOW cases and the others be
>> consistent ("ERROR: unsupported command" or similar)? It's worth
>> noting that this is only in the psql client, but we could simulate
>> the
>> ereport output from the server.
>
> No. Not unless you want to simulate it to the point of honoring the
> different verbosity settings, which would greatly expand the size of
> the
> patch. We do not try to make the response to "help" look like an
> error
> message, and I don't see the value of doing so here either.
>
> (I think Florian's real problem with the proposed output is that it's
> ugly, which I agree with --- the formatting is strange.)
I'm with you on that one; I tried to address that in the second
revision of the patch. But I'm definitely open to suggestions.
Regards,
David
--
David Christensen
End Point Corporation
david(at)endpoint(dot)com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-01-21 18:06:20 | Re: Patch: regschema OID type |
| Previous Message | David Christensen | 2010-01-21 18:04:19 | Re: Patch: regschema OID type |