Re: WIP Incremental JSON Parser

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: WIP Incremental JSON Parser
Date: 2024-03-12 01:43:33
Message-ID: 694fd815-0414-0f09-98b3-db28d77fa37f@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-03-11 Mo 09:47, Jacob Champion wrote:
> On Sun, Mar 10, 2024 at 11:43 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> I haven't managed to reproduce this. But I'm including some tests for it.
> If I remove the newline from the end of the new tests:
>
>> @@ -25,7 +25,7 @@ for (my $size = 64; $size > 0; $size--)
>> foreach my $test_string (@inlinetests)
>> {
>> my ($fh, $fname) = tempfile();
>> - print $fh "$test_string\n";
>> + print $fh "$test_string";
>> close($fh);
>>
>> foreach my $size (1..6, 10, 20, 30)
> then I can reproduce the same result as my local tests. That extra
> whitespace appears to help the partial token logic out somehow.
>

Yep, here's a patch set with that fixed, and the tests adjusted.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
v10-0001-Introduce-a-non-recursive-JSON-parser.patch text/x-patch 424.7 KB
v10-0002-Add-support-for-incrementally-parsing-backup-man.patch text/x-patch 8.1 KB
v10-0003-Use-incremental-parsing-of-backup-manifests.patch text/x-patch 11.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-03-12 01:55:53 Re: [PROPOSAL] Skip test citext_utf8 on Windows
Previous Message Nathan Bossart 2024-03-12 01:37:56 Re: Reports on obsolete Postgres versions