| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Make pgbench's expression lexer reentrant. |
| Date: | 2016-03-20 17:12:02 |
| Message-ID: | 6926.1458493922@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-03-19 20:35:48 +0000, Tom Lane wrote:
>> Make pgbench's expression lexer reentrant.
> This appears to have caused build failures on gaur, prairiedog, and
> pademelon
Yeah, I know. I have a plan for fixing it but wanted to get the
main pgbench parsing rewrite pushed first.
The problem seems to be that the ancient bison version these critters
are using has a bug for the combination of a reentrant lexer and a
non-reentrant parser. Which it's not so surprising they'd not have
tested. I think it won't be too painful to dodge this by making the
parser reentrant too (bison %pure-parser), and will look into that
this evening.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-20 21:52:00 | pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. |
| Previous Message | Tom Lane | 2016-03-20 16:59:11 | pgsql: SQL commands in pgbench scripts are now ended by semicolons, not |