| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Yuki Seino <seinoyu(at)oss(dot)nttdata(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add “FOR UPDATE NOWAIT” lock details to the log. |
| Date: | 2025-03-11 13:24:25 |
| Message-ID: | 692300f6-ac2d-4cf4-86a6-84758e507955@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/03/11 16:50, Yuki Seino wrote:
>>
>> Instead, wouldn't it be simpler to update LockAcquireExtended() to
>> take a new argument, like logLockFailure, to control whether
>> a lock failure should be logged directly? I’ve adjusted the patch
>> accordingly and attached it. Please let me know what you think!
>>
>> Regards,
> Thank you!
>
> It's very simple and nice.
> It seems like it can also handle other lock failure cases by extending logLockFailure.
> > I agree with this propose.
Thanks for reviewing the patch!
I've made some minor cosmetic adjustments. The updated patch is attached.
Unless there are any objections, I'll proceed with committing it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Add-GUC-option-to-log-lock-acquisition-failures.patch | text/plain | 24.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-11 14:10:50 | Re: Use "protocol options" name instead of "protocol extensions" everywhere |
| Previous Message | Dagfinn Ilmari Mannsåker | 2025-03-11 13:07:35 | Re: Changing the state of data checksums in a running cluster |