Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pythonesque(at)gmail(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers
Date: 2014-02-13 17:44:52
Message-ID: 6917.1392313492@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

pythonesque(at)gmail(dot)com writes:
> As in description. This follows from how these are scanned in scan.l:

> ident = litbuf_udeescape('\\', yyscanner);
> if (yyextra->literallen >= NAMEDATALEN)
> truncate_identifier(ident, yyextra->literallen, true);

Yeah, that's a bug --- yyextra->literallen is not the thing to use here.
It's just luck that truncate_identifier doesn't fail entirely, since
we're violating its API contract. Will fix, thanks for reporting it.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Joshua Yanovski 2014-02-13 18:15:12 Re: BUG #9204: truncate_identifier may be called unnecessarily on escaped quoted identifiers
Previous Message Tom Lane 2014-02-13 16:53:18 Re: BUG #9198: psql -c 'SET; ...' not working