Why does make_noname insert a SeqScan above sort/material node?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Why does make_noname insert a SeqScan above sort/material node?
Date: 1999-08-17 00:41:28
Message-ID: 6910.934850488@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Does anyone know why make_noname (in createplan.c) insists on putting
a SeqScan plan node above the Sort or Material node it's generating?
As far as I can tell, it's a waste of cycles:

1. planner.c doesn't bother with a SeqScan above the Sorts it makes.
2. The executor's nodeSeqscan.c just redirects all its calls to the
outerPlan node, if it has an outerPlan.
3. Things seem to work fine without it ;-)

However, I'm not quite ready to commit this change without consultation.
Does anyone know what this was for?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim Mikheev 1999-08-17 01:22:56 Re: [HACKERS] Re: [CORE] Re: tomorrow
Previous Message Hannu Krosing 1999-08-16 21:42:27 Re: [HACKERS] Re: your mail