| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DROP SUBSCRIPTION and ROLLBACK |
| Date: | 2017-03-04 04:46:40 |
| Message-ID: | 690625cd-5198-f788-e9d3-801ae51d2739@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/3/17 13:58, Petr Jelinek wrote:
> On 23/02/17 08:24, Masahiko Sawada wrote:
>> Attached updated version patches. Please review these.
>>
>
> This version looks good to me, I'd only change the
>
>> + PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION CREATE SLOT");
>
> to "CREATE SUBSCRIPTION ... CREATE SLOT" as that's afaik how we do it
> for other commands (and same with DROP).
I have committed fixes for these issues.
I didn't like the syntax change in DROP SUBSCRIPTION, so I have just
fixed the parsing of the existing syntax. We can discuss syntax changes
separately. The second patch I have committed after some editing. I
think it was generated on top of the existing data copy patch, so it was
a bit of a mess.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-04 05:39:40 | Re: Performance degradation in TPC-H Q18 |
| Previous Message | Amit Kapila | 2017-03-04 04:37:50 | Re: [BUG FIX] Removing NamedLWLockTrancheArray |