Hi hackers,
I found probably something to fix in pg_walsummary.
pg_walsummary specifies “f:iqw:” as the third argument of getopt_long().
> /* process command-line options */
> while ((c = getopt_long(argc, argv, "f:iqw:",
> long_options, &optindex)) != -1)
However, only i and q are valid options.
> switch (c)
> {
> case 'i':
> break;
> case 'q':
> opt.quiet = true;
> break;
> default:
> /* getopt_long already emitted a complaint */
> pg_log_error_hint("Try \"%s --help\" for more information.",
> progname);
> exit(1);
> }
Therefore, shouldn't “f:” and “w:” be removed?
Best regards,
Yusuke Sugie