| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: tests fail on windows with default git settings |
| Date: | 2024-07-09 15:34:24 |
| Message-ID: | 68d948a3-704a-4a0e-a7c9-0591f4ade7ce@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-07-09 Tu 9:52 AM, Dave Page wrote:
>
>
> > What I suggest (see attached) is we run the diff command with
> > --strip-trailing-cr on Windows. Then we just won't care if the
> expected file
> > and/or the output file has CRs.
>
> I was wondering about that too, but I wasn't sure we can rely on
> that flag
> being supported...
>
>
> I have 4 different diff.exe's on my ~6 week old build VM (not counting
> shims), all of which seem to support --strip-trailing-cr. Those builds
> came with:
>
> - git
> - VC++
> - diffutils (installed by chocolatey)
> - vcpkg
>
> I think it's reasonable to assume it'll be supported.
>
Ok, cool. So I propose to patch the test_json_parser and pg_bsd_indent
tests to use it on Windows, later today unless there's some objection.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2024-07-09 15:38:02 | Re: jsonpath: Inconsistency of timestamp_tz() Output |
| Previous Message | Tom Lane | 2024-07-09 15:31:22 | Re: array_in sub function ReadArrayDimensions error message |