| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical decoding / rewrite map vs. maxAllocatedDescs |
| Date: | 2018-08-11 14:15:56 |
| Message-ID: | 6899.1533996956@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>>> On 08/09/2018 07:47 PM, Alvaro Herrera wrote:
>>>> Actually, it seems to me that ApplyLogicalMappingFile is just leaking
>>>> the file descriptor for no good reason.
> I think the fix can be as simple as attached ... I'm mostly afk for the
> weekend, so I'll commit & backpatch on Monday or so.
LGTM. While you're at it, would you fix the misspelling three lines
below this?
* Check whether the TransactionOId 'xid' is in the pre-sorted array 'xip'.
^
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-08-11 14:17:48 | Re: buildfarm: could not read block 3 in file "base/16384/2662": read only 0 of 8192 bytes |
| Previous Message | Andres Freund | 2018-08-11 14:08:23 | Re: buildfarm: could not read block 3 in file "base/16384/2662": read only 0 of 8192 bytes |