| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: APR 1.0 released |
| Date: | 2004-09-09 16:58:21 |
| Message-ID: | 6891.1094749101@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I'm not sure exactly what Bruce checked, so I just spent a few cycles
> making sure that we did not inadvertantly pick up a define of WIN32 from
> windows.h anywhere else. I *think* we are OK on that. However, ISTM this
> is a foot just waiting to be shot - in retrospect using WIN32 as our
> marker for native Windows, which we do in a great many places (around
> 300 by my count) was a less than stellar choice, given that it is
> defined by windows.h, and especially since we use that header for Cygwin
> as well as for Windows native in a few places.
Well, it's easily changed, if all that's needed is a search-and-replace.
Suggestions for a better name?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2004-09-09 16:58:23 | Re: psql questions: SQL, progname, copyright dates |
| Previous Message | Andrew Dunstan | 2004-09-09 16:45:46 | Re: APR 1.0 released |