From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: MSVC buildfarm critters are not running modules' TAP tests |
Date: | 2019-09-08 22:14:52 |
Message-ID: | 688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 9/8/19 5:59 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> On 9/8/19 12:07 PM, Tom Lane wrote:
>>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>>> subroutine subdircheck isn't considering the possibility that
>>> subdirectories of src/test/modules contain TAP tests. The
>>> same code is used for contrib, so several existing TAP tests
>>> are being missed there too.
>> Actually, I think vcregress.pl is OK, this is a gap in the buildfarm
>> client's coverage that will be fixed when I make a new release.
> Hm. Changing the buildfarm script would be an alternative way to
> fix the issue so far as the buildfarm is concerned, but it doesn't
> seem like it provides any useful way for one to manually invoke
> the tests on Windows. Or am I missing something about how that's
> usually done?
>
>
The invocation is:
vcregress.pl taptest [ PROVE_FLAGS=xxx ] directory
directory needs to be relative to $topdir, so something like:
vcregress.pl taptest src/test/modules/test_misc
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-08 22:18:33 | Re: MSVC buildfarm critters are not running modules' TAP tests |
Previous Message | Andrew Dunstan | 2019-09-08 22:06:34 | msys2 vs pg_upgrade/test.sh |